-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > > as keys, and call the method . > > That's why I suggested all those methods that take things like > integer arguments for HTL, etc., ought to be recoded to take nothing > but the message object, and get those values from the message's > FieldSet itself. That delays decoding to the very last moment, and > perhaps requires some extra encodes and decodes, but dozens of methods > suddenly lose lots of arguments, classes start looking alike so more > code sharing becomes available, the code is simpler to read, etc.
And requires that each such method you call be transmitted the entire message. Thats ugly, because it duplicates transmission. > Even if we weakly type the fields, these methods should still be > fixed not to pass fields values explicity as arguments, but to look > them up from the message's FieldSet (which now has to have typed > getters and setters that would also be eliminated by just making > everything a string). Not a good idea, for above reason. You're also making the assumption that every method you're calling is as broad based as that.. How about this, for example: compareKey(long key) Under your model, it would be: compareKey(Message m). Which would require transmitting the entire message just to get at one field. compareKey(String key) is worse, since it would require twice as many characters, plus a parse. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.1 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE5IE/rpXyM95IyRhURAnPZAKDIvw8ENQQGYE/J219aXAvFDIBDPwCfZE8X ZN6l48zhaRIMbPiPQSq9mcs= =nrNd -----END PGP SIGNATURE----- _______________________________________________ Freenet-dev mailing list Freenet-dev at lists.sourceforge.net http://lists.sourceforge.net/mailman/listinfo/freenet-dev
