* Sven-Ola Tuecke <sven-ola at gmx.de> [2008-03-12 14:52:33]: > NextGen$, > > ok - I'll explain hunk by hunk. > > Hunk1: You can apply this one or correct the bdb version in your repo. > Examples and unittest subdirs are simply missined from freenet CVS copy > of bdb.
Missing parts are easy to filter out of a diff, mangled parts aren't > > Hunk2: Building bdb simply outputs the jar into ../bdb/build/lib if you > "cd freenet-ext;ant". Not in ../bdb/lib. Please verify - again you may > have a local leftover from an earlier version or so. > Ok for that one (it was in lib/ on previous versions of bdb), merged in r18502. > Hunk3: IsProbablyPrime() is buggy in both SUN and GNU implementations > IMO. Those should throw an exception, because 0 and 1 are not primes nor > non-primes (simply do not fit in the category, ask your local math > crack). The GNU impl is more plausible, so you may change to > "assertTrue(DSAGroupGenerator.isPrime(BigInteger.ONE));" and wait for the > SUN-runtime bugfix. > Ok, let's fix it properly then, see r18503. > Hunk4: Obviously, the GNU implementation cuts of IPv4 after the 4th > digit, then verify. I don't think thats critical, but one may overload > that function and change the func for the sake of correctness... > Well, I don't want to get rid of this test. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20080313/e08a5d0b/attachment.pgp>
