On Friday 03 July 2009 15:04:25 sashee wrote:
> On Fri, Jul 3, 2009 at 2:01 AM, Matthew
> Toseland<toad at amphibian.dyndns.org> wrote:
> > On Friday 03 July 2009 01:00:00 Matthew Toseland wrote:
> >> 1794de9ad5df4b2cdb3bbb8f0a89c3e4da6e3175 :
> >>
> >> + ? ? ? private int getTime(){
> >> + ? ? ? ? ? ? ? return (int)(System.currentTimeMillis());
> >> + ? ? ? }
> >> +
> >>
> >> - you will get wrap-around problems when checking the keepalive in
> >> followerTakeOverTimer, no??
> >>
>
> It is a bug, but actually it doesn't do any wrong. I've corrected it
> anyway. Because javascript has no variable types, it ignores castings.
> Because of this, it worked well.
>
> >>
> >> logToWindow
> >> - unsafe due to not encoding; not a problem if no end user ever runs this,
> >> but should document?
> >>
>
> fixed, escaping ". HTML tags doesn't need escaping here, GWT does this
> automatically.
>
> >>
> >> testing:
> >> imho requests stall, both mid-way and at 100%.
> >> requests definitely stall at 100% - stuck on 100% for minutes, reload
> >> manually and it immediately shows content type warning.
> >> definitely stall below that too, doing same trick shows much progress.
> >>
> > This might explain some of the problems:
> >
> > Jul 02, 2009 23:58:36:359 (java.lang.Class, HTTP socket handler at
> > 763900730(47), ERROR): Caught error: java.lang.NullPointerException
> > handling socket
> > java.lang.NullPointerException
> > ? ? ? ?at
> > freenet.clients.http.updateableelements.PushDataManager.getNextNotification(PushDataManager.java:166)
> > ? ? ? ?at
> > freenet.clients.http.PushNotificationToadlet.handleGet(PushNotificationToadlet.java:24)
> > ? ? ? ?at
> > freenet.clients.http.ToadletContextImpl.handle(ToadletContextImpl.java:372)
> > ? ? ? ?at
> > freenet.clients.http.SimpleToadletServer$SocketHandler.run(SimpleToadletServer.java:694)
> > ? ? ? ?at
> > freenet.support.PooledExecutor$MyThread.run(PooledExecutor.java:224)
> >
>
> It is now should be fixed. Found some horrible bugs that caused
> stalling, and fixed them. I'm testing it for some time, and haven't
> experienced any stops yet. Please mail me if you experience it
> further.
- if (fr.isFinished()) {
+ if (fr.isFinished() || fr.hasData() || fr.failed != null) {
Is it possible for fr.isFinished to be false when fr.hasData is true or
fr.failed is non-null? (I'm not saying take it out, but is isFinished() buggy
or am I missing something?)
If you think the code is working, you should post a jar somewhere and ask for
wider testing on devl.
Blocks seems to get reset to 0 / 0 after a while at 100%, any ideas why?
"ETA: -9s" is probably not what we want. :)
And I did get one page to stall. It was in the datastore and loaded instantly
when I clicked on the url and pressed enter, but until that point it went
nearly 3 minutes without progress, showing 0 / 1 blocks and updating only the
time counter.
The URL was this, but I doubt it's a problem with the page.
http://127.0.0.1:8888/freenet:USK at
MJbn3mnX5J5xOa-OSOcCjtwRVTwj5R52wN4XtKW64yQ,NYAzL61qMPrAYC8B7Anpwx8h7CPYzBnpJIZNVgnR1rU,AQACAAE/Chaosradio/43/ChaosradioExpress/index.html
I had a different problem with another page, a file stalled close to the end,
showing no new blocks, no failures, but when I reloaded it showed a MIME type
warning page instantly. I'm not sure what's going on there, it might be some
wierd interaction with the FProxy fetch code. Nothing obvious in the logs (NPEs
etc).
Arguably we should show the mime type warning as soon as we know the mime type,
but it may be best to keep the current behaviour for now.
If a request is being answered from the datastore, is it possible that the
events from that one request could overwhelm the events from the other
requests, and thus that they might not show progress when there was progress?
You might want to throttle events on the node side so we don't send more than 1
per 100ms from each request, or something?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20090703/f51fa32a/attachment.pgp>
