On Thursday 03 June 2010 23:58:31 you wrote:
>
> spencerjackson wants you to pull from spencerjackson/fred-staging at
> ContentFilter
>
> Body: Moves content filtration to the client layer. In this branch, the
> content filter is called from ClientGetter's onSuccess method, depending on
> whether or not a variable is set in the FetchContext. Other filter related
> variables are placed into the Context. Changes, both visible and invisible,
> are made to FProxy, enabling it to create multiple fetches for the same key,
> with slightly different FetchContexts, and placing checkboxes to toggle
> filtration. By default, filtration is enabled for FProxy. For FCP, filtration
> is disabled by default, but may be enabled by added FilterData=true to the
> ClientGet message.
>
> View repository:
> http://github.com/spencerjackson/fred-staging/tree/ContentFilter
>
Ok. I don't plan to merge this before 1248, which should be real soon, but
which so far I have been delaying until the Spider/Library changes are ready. A
very brief look over it:
I don't understand
56ddea7c8ae4f13dc35b0b3c7f7c93b5a867bc0f ("Store a request's charset in
FetchContext for the filter"). If the charset is provided on insert then it
will be part of the MIME type on the ClientMetadata. If it's not we have to
autodetect it, in which case we should update the MIME type somehow.
Overriding the MIME type in the FetchContext does however make sense. You might
want to investigate its interaction with transparent unpacking. Transparent
unpacking = insert data as a zip at CHK at blah, then access it as CHK at
blah/fileinzip.txt.
Re FetchContext.hashCode(), many of the elements on FetchContext are mutable
IIRC, so if changed on the fly could change the hashCode, so be careful ...
Hmmm, you removed this code anyway...
Anyway, good stuff, I'll try to get it merged in the not too distant future.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20100605/ef786666/attachment.pgp>
