On Tuesday 11 May 2010 04:16:02 you wrote:
>
> spencerjackson wants you to pull from spencerjackson/fred-staging at
> HTMLAttributeReorder
>
> Body: This fixes the content filter's tendency to reorder attributes as they
> are filtered. Also it shows how tags, whose attributes have been completely
> removed, may be removed from the final output, if failing to do so would
> result in invalid HTML.
>
> View repository:
> http://github.com/spencerjackson/fred-staging/tree/HTMLAttributeReorder
>
This needs some work before it can be merged. Specifically, you can't override
allowedAttrs to include locally verified attrs, because allowedAttrs is already
used for a list of attributes that are passed through unfiltered (arguably this
is a bad thing and we should write parsers for them). Thus overriding it in
this way results in all these attributes being lost. Please fix this, and you
might like to write a unit test demonstrating it (have a look at what tags use
allowedAttrs), and then send another pull request. Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20100514/2c286b1d/attachment.pgp>
