On Friday 11 June 2010 14:43:09 Matthew Toseland wrote: > BEFORE RELEASING 1251, MUST FIX: > - Internal error on persistent download for mp3 with the check filter flag > enabled. This should be an unfilterable content error.
I fixed the internal error, was returnBucket-related (resulting from a previous tweak I made). Doh. > - WoT > - Freetalk > - Spider > - XMLSpider > - FlogHelper > - BMP filter failure in unit tests. > - dangerousInlines not dangerousInline > - Are self-closing tags an issue on truncated filtering in HTMLFilter? I > doubt it but double-check what the behaviour is on EOFing when in the middle > of a string. > - ContentFilter charset detection code MUST use readFully, or a loop > achieving similar goals. read() doesn't read the full buffer. > > Minor stuff: > > [01:31:51] <toad_> third, CharsetExtractor taking a byte[] of unspecified > size is a bit strange, you should have CharsetExtractor tell the caller how > big the buffer should be > > 3fcc1ac770ad0e360b49984521e1977353d933ab > - close the streams before freeing the buckets > > 6fd6f8c50ffc4823c2d3c701e0c85c6155039e2a > - BMPFilter, CSSReadFilter, GIFFilter, HTMLFilter: don't flush in finally > - JPEG filter: don't flush on writing a frame, flush at the end (when > returning/exiting the loop). > > 15b6283e017a26dec96f35820028b84992b5260f > - should pass the overridden mime type along in places where we generate > expected mime type events as well. non-critical. > - should maybe also pass it in other places where we set the expected mime > type on FetchException's. again non-critical. > > 9c05c0b1d1840826d6e823dc7f9f46682a3afac8 > (f0dddb70e787388f3a674e9530e44962ce43d1c3 improves a bit) > - what about just calling getMessage() on FetchException? > -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 197 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20100611/a24b3940/attachment.pgp>
