On Friday 05 November 2010 22:37:48 Robert Hailey wrote: > > A working implementation is visible here: > > https://github.com/Osndok/fred-staging/tree/depth-first-announcement > > With a simulator that shows that: > (1) it doesn't break announcements, > (2) it seeks the deepest nodes first (away from the seed node), > (3) it gathers at most MAnnounceSender.MAX_ANNOUNCE_REPLIES (and in my > sim run, precisely that many) > > For some reason github won't let me issue a pull request at the moment.
I don't have time to review this code right now. However if you want "depth first announcement" accepted first you have to: 1) Show that we are rejecting nodes from announcement towards the end of the path, having accepted too many early on, and 2) Produce a patch that accepts preferentially from the end; as far as I can see yours doesn't. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 197 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20101106/ca9e4a26/attachment.pgp>
