I'm almost done. I want to commit ASAP (like in half an hour) but there are two things that stop me:
(1) I added a parameter in xwiki.cfg (xwiki.wysiwygnew=[1|0]) for enabling/disabling the experimental editor. I need to retrieve its value in a template like edit.vm. How should I do it? Options: * Add a isWysiwygNewEnabled() method in XWiki. I don't like this solution because XWiki is already too crowded. * Create a WysiwygPlugin that we can extend later, and which will contain for the moment just a isEnabled() method. * Something else? (2) "New WYSIWYG (experimental)" is too long for the EditModes panel (it breaks in two lines). Is it ok to leave just "New Wysiwyg"? WDYT? Marius > 11 +1 > > I'll move the new WYSIWYG into the platform tomorrow morning. > > Regarding the integration, I forgot one important detail that may cause > some problems: the GWT version. A few weeks ago I switched from 1.4.61 to > 1.5-rc1. The latest version is now 1.5-rc2 and I believe they will soon > provide a final 1.5 version (AFAIK, there's no publicly available > roadmap). Some of the reasons that made me move to GWT 1.5 are: > > * Java 1.5 goodies (use of generics instead of @gwt.typeArgs annotations) > * Improved API (Element#getInnerHTML() instead of > DOM#getInnerHTML(Element)) > * Curiosity > > Right now, platform-web-gwt depends on GWT 1.4.61. It seems to work on 1.5 > since the new WYSIWYG depends on it and on GWT 1.5. So, what are the > options? > > * Move platform-web-gwt to GWT 1.5 (but may cause problems in other > projects like Watch and Curriki) > * Use maven magic to obtain a special XE distribution which will include > the new WYSIWYG and will depend on GWT 1.5 (but we won't have the new > WYSIWYG in the default distribution) > * Degrade the WYSIWYG to GWT 1.4 (but it will make me unhappy) > * Something else? > > So WDYT? > Marius > >> Hi devs, >> >> I propose to move the new WYSIWYG editor into the platform in order to >> have it as an experimental feature for 1.6M1. >> >> The following steps should be taken: >> * Create a platform/web/wysiwyg module to host the code currently >> resided >> in sandbox/wysiwyg >> * Change templates/edit.vm, templates/editpanels.vm and create >> templates/editwysiwygnew.vm to make XE aware of the new editor. This way >> our users will be able to experiment the new WYSIWYG editor on any page, >> by having editor=wysiwygnew in the edit URL. >> * Change platform/web/pom/xml and enterprise/web/pom.xml >> >> Here's my +1 >> Marius >> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
