Vincent Massol wrote: > On Mar 25, 2010, at 1:11 PM, Caleb James DeLisle wrote: > >> Hello all, >> I'd like to make this change: >> >> Add to xwiki.api.Document >> saveAsAuthor() >> saveAsAuthor(String comment) >> saveAsAuthor(String connent, String isMinorEdit) >> deleteAsAuthor() >> >> Add to xwiki.api.XWiki >> getDocumentAsAuthor(DocumentReference reference) >> getDocumentAsAuthor(String fullName) >> >> They save, load or delete the document if the script's contentAuthor has the >> necessary permission, the user in >> context is switched so the contentAuthor is listed as having done the >> operation. >> >> Though they say *AsAuthor the action will take place in the name of the >> contentAuthor of the document >> this is mainly because *AsContentAuthor is long and confusing. > > Responding a bit late on this. > > I'd have preferred AsContentAuthor for the name. Actually AsAuthor is > misleading since > you're expecting an author to be passed as a parameter. You mean I'm not expecting an author parameter? there are no parameters except for the getDocumentAsAuthor methods which need the document name/reference.
> SaveWithCurrentContentAuthor would have been better IMO. "would have" I can still change it if you feel strongly about this but getDocumentWithCurrentContentAuthor is a lot to type and it implies that we are getting a document which has a given content author. > > What is the underlying use case? Is it for the cases when someone edits a > page but makes no changes? (for this case I think we shouldn't save the doc > and create a revision). Suppose you wanted to make a script which let people sign up to a mailing list by submitting their email address. Your script must save the email to an object in a document somewhere but can't let the viewer actually edit or even view the document thus reading the email addresses of other previously signed up users. > > If I add objects or attachments then the doc will be saved as the last > author. That doesn't look right to me. The notification will be sent with the > previous author's name, no? (I haven't checked your patch or the existing > code though so I may be wrong). You (the viewer) should never be able to use these functions, they are only for the script author of document x to be able to use their script to save document y based on input from a user who may not save document y. Caleb > > Thanks > -Vincent > >> This is already partially available if the script has programming access but >> I think it is an important >> enough feature that it should not be limited to scripts with programming >> access. >> Use case: allowing users to submit information without letting them see or >> modify what other users had submitted. >> >> This is my +1 >> >> Caleb > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
