On Tue, Nov 5, 2013 at 11:35 AM, Caleb James DeLisle <[email protected]>wrote:
> I'd hate to include patched binaries in the project because that makes > it completely unmaintainable to the next person, right now it builds > each of it's needed elements so the work could theoretically be picked > right back up where it stopped. > I guess I wasn't clear. You should definitely never bundle binaries in the source tree of course! But you can depend on binary artifacts in your POM files... I suppose I could ship a big-ugly-patch and include a patch step in the > shell script but I won't have time to run this through all of the tests > so this will be a bit of a Hail Mary change.. > Either a patch or use all the existing extension points available. Like replace the storage by configuring xwiki.cfg, etc. Thanks -Vincent > > Thanks, > Caleb > > On 11/05/2013 11:26 AM, Vincent Massol wrote: > > On Tue, Nov 5, 2013 at 11:23 AM, Caleb James DeLisle <[email protected] > >wrote: > > > >> Hi guys, > >> It's been a while since this demo was created but I was looking at > >> my github and it has not been touched so I would like to document it > >> and put it in contrib where it's available. > >> > >> I have a question about technique, this demo builds on the standard > >> version of xwiki-platform but requires a special version of > >> xwiki-enterprise. > >> Is it ok to have a long term branch in the xwiki-enterprise repository > or > >> should the entire repository be copied into contrib? > >> > >> WDYT? > >> > > > > hmm, why don't you depend on binaries instead in your build? > > > > This is what I did for some project and it worked well. > > > > Thanks > > -Vincent > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
