Hi again, Just checked the maven build and found several issues that I’ve fixed.
Also noticed there’s no functional tests at all. Could you please focus on having at least the infrastructure ready with a simple test that simply goes to the home page of the RedPen app for ex? You can check https://github.com/xwiki-contrib/application-faq/tree/master/application-faq-test as an example; it’ll be very very similar. See also http://dev.xwiki.org/xwiki/bin/view/Community/Testing#HFunctionalTesting Thanks -Vincent > On 6 Jul 2017, at 17:46, Vincent Massol <[email protected]> wrote: > > Hi Desheng, > >> On 5 Jul 2017, at 06:32, deshengchuan <[email protected]> wrote: >> >> Good day to all. >> First, a quick update on the current status of the redpen extension: >> It is now renamed as Content Checker, in consideration of implementing other >> document checking technology in the future. Also content checker's results >> are currently shown as logs, and the messages are split into warnings and >> errors. Also, during automatic validation of a document on save, if an error >> exists, the save is canceled. > > Sounds good for now. How do you configure if a check is a warning or an error? > >> Next, I am in the middle of adding most of the available validators from >> redpen as a configurable setting. However there are validator settings that >> require a dictionary i.e. Invalid words, suggested words and expressions. To >> this end, I plan to reformat the application homepage, > > Could you show us a screenshot of the current home page? > > Also, is it possible to try the application right now? Can I build it and > install it in my wiki? Is it going to work? > >> to add a select field >> before the user enters into the text input fields, indicating whether the >> entry for invalid words or for suggested words and expressions. > > Not quite clear what you mean. A mockup or screenshot on the design page > would be great. > >> Further, I have been looking for a way to extract the live table data within >> Java, but have been unable to. Is there a way to do it? > > You’ve use AWM to create the app? If so you should instead use the manual way > as for the FAQ app tutorial here: > http://platform.xwiki.org/xwiki/bin/view/DevGuide/FAQTutorial/FAQTutorialManual > > If you follow this tutorial you should be able to answer your question I > think. > > To query xobject data you should use the QueryManager (see > http://extensions.xwiki.org/xwiki/bin/view/Extension/Query%20Module#HFromJavacomponents). > >> Lastly, as the number of validation settings pile up, I plan to reformat the >> UI of the configurable class of my app to one that is tabbed, like the >> WYSIWYG configurable class in the administration wiki, to achieve a cleaner >> look. > > In order to help you it would be much nicer if you could show some > screenshots/mockups of what you have and what you’d like to have so that we > can provide feedback. If you do it and show it after it’s done then you might > need to fully redo it if it doesn’t go in the right direction so I feel it > could save you time if you could show something. > > People also usually are more inclined to provide feedback when they see > visually the things. > >> I would greatly appreciate any comments on the above implementation plans, >> thanks! > > I haven’t checked the code yet after my comments (I think there are still > some comments I’ve mentioned that don’t have an answer; I remember asking you > for an example of a setting since I believe a List is not the right format). > > Globally looking good! Now we need to validate the code base so far (I’m a > bit worried on the configuration aspect since it was completely off initially > - you were not using the xwiki configuration mechanism). Will check now. > > Thanks! > -Vincent > >> >> >> >> -- >> View this message in context: >> http://xwiki.475771.n2.nabble.com/GSOC-Update-4-Design-RedPen-Integration-tp7604291.html >> Sent from the XWiki- Dev mailing list archive at Nabble.com. >
