> On 11 Jul 2017, at 17:17, deshengchuan <[email protected]> wrote: > > Hi, sorry for the late reply. > > >> Ok so it’s hardcoded and thus static ATM. >> >> A simple solution is simply to introduce a configuration API in the >> CheckerConfiguration interface: >> >> Map >> < >> String, SeverityLevel >> > >> getSeverityLevels() >> >> Note that in xwiki.properties it’ll be defined as: >> >> redpen.severityLevels = SuccessiveWord = warning >> redpen.severityLevels = DoubleNegative = error >> … > > Alright will work on this. Just to confirm with you, this means I would have > to instantiate another configurationsource object to obtain the data, this > one being xwikicfg configurationsource, right?
In XWiki you don’t instantiate component: instead you ask to be injected, using @inject. In this case you ask to be injected a Configuration Source. You’re probably already doing that. So there should be nothing to do if you use the “default” ConfigurationSource for example because it’ll fall back on other sources, including the “xwikiproperties” ConfigurationSource. > >> ok I’ve checked it and I don’t really understand why you have an app home >> page + an Admin UI page. Aren’t they both about admin configuration of >> RedPen? Why not a single place? > > Hmmm.. I have been thinking about this design for a while. I feel that this > home page is essentially dictionary of entries of invalid or > less-than-perfect entries, which means it is going to store plenty of data, > all of which is best displayed in a livetable macro for easy review and > editing. Hence, I think there should be a separate section in the admin UI > dedicated to showing the entries of the dictionary. > > I have updated the UI accordingly in the proposal, please feel free to take > a look. For quick reference, the "Dictionary" part is as follows: > http://design.xwiki.org/xwiki/bin/download/Proposal/RedPenIntegration/updated_admin_ui_2.PNG > <http://design.xwiki.org/xwiki/bin/download/Proposal/RedPenIntegration/updated_admin_ui_2.PNG> > Cool, that looks nice (the two tabs!). Note that you seem to be missing some translation in the screenshot but that’s a detail. Thanks -Vincent > > -- > View this message in context: > http://xwiki.475771.n2.nabble.com/GSOC-Update-4-Design-RedPen-Integration-tp7604291p7604345.html > Sent from the XWiki- Dev mailing list archive at Nabble.com.
