On Tue, May 29, 2018 at 6:48 PM, Vincent Massol <[email protected]> wrote:
> Hi Caty, > > > On 29 May 2018, at 17:23, Ecaterina Moraru (Valica) <[email protected]> > wrote: > > > > Hi devs, > > > > Just to make sure we are on the same page since there were some > ambiguities > > on the proposal, I've put some screenshot on how it will look like: > > http://design.xwiki.org/xwiki/bin/view/Proposal/ > IdeaVisibleSave#HProposal10.x > > Could you give some context to explain why we need a VOTE and what you’re > asking to VOTE about? > Ok, maybe vote is not good since I'm also asking for feedback in the mail. The issue with this proposal is that it's a design proposal, not a full implementation proposal. So depending on how the developer will implement it we might need to iterate more, and at this stage of the proposal it's hard to know how things will end up. > > AFAIK there’s no need to VOTE on having Visible Save button since: > * We already discussed and decided to implement visible save > * It was already put twice in the roadmap and is currently in the 10.5 > roadmap (which is already started), and nobody complained > > So if your email is about bringing some variations to what was decided, > it’s fine but why does it need a VOTE? A simple proposal would have been > enough IMO. > > > This proposal extracts the save controls and puts them on a fixed bottom > > bar. > > Does it mean that the vertical space for the editor is constrained and can > never be larger than the viewport minus the vertical space for the save bar? > > Also on the http://design.xwiki.org/xwiki/bin/download/Proposal/ > IdeaVisibleSave/after10.png screenshot the bar takes the full width but > on the followings screenshots the bar doesn’t. What is proposed precisely? > > Could you explain what’s different between "Proposal for 9.x" and > "Proposal for 10.x" on http://design.xwiki.org/xwiki/bin/view/Proposal/ > IdeaVisibleSave#HProposal10.x I've made a separate heading because there are some visual difference (because of the ColorTheme change). Proposal 10.x is made with more screenshots so that is clear how it should look in the end. Trying to be very clear and have less ambiguities. For the inline mode I've put 2 variations, 1 full width and the other as current. Again, this depends if we want to add JS to the solution, if we can find a CSS only solution, etc. Depends on the implementation. Thanks, Caty > > > I’ve checked quickly and I don’t see any difference visually. > > > There are some problems with the inline mode and with the responsive > > versions. > > With the inline version we could decide to keep the current > > behavior and have the fixed bar only in Wiki and WYSIWYG modes. I guess > we > > should do some implementation tests and see what's possible. > > What problems? > > At this stage I can’t VOTE since I don’t know what’s the question and it > seems to be missing some details (see my questions above). > > Thanks > -Vincent > > PS: It’s sad that we are so late on the design of visible save since we’ve > had months to plan this. It was already put in a roadmap at least 6 months > ago and then not finished and then put again in the roadmap several months > ago. We could have had plenty of time to discuss/tune this. Now this means > we are at risk of not finishing this for 10.5. Let’s hope we can catch up. > > > > > Thanks, > > Caty > >
