Many thanks to Alex for the ongoing code review.
As for the minimal XWiki version requirement: due to my limited experience, I have (of
course) no strong feeling. I have updated the version to "2.0" to reflect a
change in the default settings as suggested by Thomas. Considering 1) the amount of
testing needed to make sure that the macro works fine with versions 5.x and 6.x, 2) the
fact that it's good practice to put all macros in a common space, I would tend to favor a
compatibility with an XWiki version supporting nested pages, but let me know what you
prefer and I'll be happy to proceed.
Cheers,
Stéphane
Vincent Massol:
Hi Alex,
I think we could up that minimal requirement to 7.x or even 8.x.
WDYT?
Thanks
-Vincent
On 9 Jul 2018, at 13:37, Alex Cotiugă <alexandru.coti...@xwiki.com> wrote:
Hi Vincent,
The minimal XWiki version supported by the Map Macro is XWiki 5.4-2 and we
can't use nested pages, for the moment. MapMacro space as parent sounds
good.
Thanks,
Alex
On Mon, Jul 2, 2018 at 7:37 PM, Vincent Massol <vinc...@massol.net> wrote:
Hi Stephane and all,
I see in your last commit:
M src/main/resources/MapMacro/Code/GoogleMap.xml
M src/main/resources/MapMacro/Code/LeafletMap.xml
M src/main/resources/XWiki/MapMacro.xml
M src/main/resources/XWiki/MapMacroTranslations.fa.xml
M src/main/resources/XWiki/MapMacroTranslations.fr.xml
M src/main/resources/XWiki/MapMacroTranslations.hr.xml
M src/main/resources/XWiki/MapMacroTranslations.sk.xml
M src/main/resources/XWiki/MapMacroTranslations.xml
I’m thinking that maybe we should put all the pages in the same space for
the MapMacro.
Right now we usually put Macros in the Macros space as a best practice.
Usually those wiki macros have a singe wiki page.
So I’m proposing to have all the Map Macro pages located in
Macros.MapMacro.*
WDYT?
If we agree we should also add this to https://dev.xwiki.org/xwiki/
bin/view/Community/ApplicationDevelopmentBestPractices
Thanks
-Vincent
On 2 Jul 2018, at 17:42, Ludovic Dubost <ludo...@xwiki.com> wrote:
Yes I'm +1 to move to OSM being the default
Ludovic
--
*Ludovic Dubost*
*Founder and CEO*
ludo...@xwiki.com
skype: ldubost
Blog: http://blog.ludovic.orgTry XWiki on the cloud
<http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad:
Secure
realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 4:31 PM, Stéphane Laurière <slauri...@xwiki.com>
wrote:
Hi Alex, Ludo, all,
Thanks for your feedbacks. I created a pull request which now includes
OSM
geocoding and opens OSM directions when clicking on the marker:
https://github.com/xwiki-contrib/macro-map/pull/9
As for the default value, now that OSM geocoding is supported I'd rather
be for using it but on the other hand it's true that it will have an
impact
on existing instances...
Stéphane
Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially
with
the changes Google is giving and the fact that it requires a key by
default.
Now indeed this is unsual to change the default as it might break the
cases
where geocoding was used until we support geocoding as part of the OSM
macro
Ludovic
--
*Ludovic Dubost*
*Founder and CEO*
ludo...@xwiki.com
skype: ldubost
Blog: http://blog.ludovic.orgTry XWiki on the cloud
<http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad:
Secure
realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă <
alexandru.coti...@xwiki.com
wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have
one
implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière <
slauri...@xwiki.com>
wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap
provider ?
My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples:
https://
{s}.tile.openstreetmap.org/{z}/{x}/{y}.png
<http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png>
<http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://
{s}.
tile.stamen.com/toner/{z}/{x}/{y}.png
<http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
<http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either
"leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the
tile
URL is not needed as it's necessarily the one by Google and it's
configured
by the library itself. It "leaflet" is chosen, it remains possible to
use
Google Maps tiles (not sure the macro will support it though):
https://ivansanchez.gitlab.io/Leaflet.GridLayer.
GoogleMutant/demo.html
Stéphane
Ludovic
--
*Ludovic Dubost*
*Founder and CEO*
ludo...@xwiki.com
skype: ldubost
Blog: http://blog.ludovic.orgTry XWiki on the cloud
<http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad:
Secure
realtime Wysiwyg Editing <https://cryptpad.fr>
--
Stéphane Laurière
XWiki www.xwiki.com
@slauriere
--
Stéphane Laurière
XWiki www.xwiki.com
@slauriere
--
Stéphane Laurière
XWiki www.xwiki.com
@slauriere
