On 27 Jan, Lars R. Clausen wrote:
>
> Ok, here's a diff that adds defaults dialogs for the various line tools,
> arrowheads, middle button menus, polyline, this time with save/load working
> properly.
Ok. I commited parts of this. I did rewrite the Object Menu handling,
as that was not completely kosher. (It called app/* from an object,
which is forbidden, and it had some 64bit cleanness problems. It was
also not possible to add other stuff to the object menu, as the object
created the whole menu. Now the menu is just described by the object,
but created by the app.)
Some other comments:
* You forgot to do i18n (gettext) on some string. This is quite new, so
i don't think you saw it.
* I moved back the ArrowType enum to arrows.h, as i feel it belongs
there. It's not really part of the renderer but one level above it.
* Some debug printouts and small indentation/whitespace changes were
not applied.
* Some old object_menu_register definitions were removed from menus.h.
* At some places in the code you used diagram_get_sorted_selected() to
get the list of selected objects. This is not needed. Just use the
selected field in the DiagramData structure. That function sorts the
selection in the same order as the object in the layer, which isn't
needed in this case.
* Maybe some other stuff added/changed...
> There's a few bugs I know of:
> The arrowheads for arcs don't point the right way. Still have to sit down
> and figure out the right way to do this.
Also, some arrows (like hollow triangle) looks WAY better if you fill
with background before drawing the arrow. That way you don't see the
line through the arrow.
> Lines still have the crashbug we've been talking about.
Yepp. We'll have to continue looking for that.
> There's no way to change the size of the arrowheads.
Or their angle (sharp or blunt).
> There's no default middle button menu.
No, and no standard items after the ordinary object menu items.
> After the diffs is a uuencoded tarball of the new files needed (polyline,
> defaults). Is there a way I can force them into the diff?
Hmm. I don't know. I don't think so.
/ Alex
