On 4/2/13 10:13 PM, Jonathan M Davis wrote:
On Tuesday, April 02, 2013 17:01:32 Walter Bright wrote:
On 4/2/2013 4:55 PM, Jesse Phillips wrote:
I usually find the build in unittests to cause more skew since those are
counted as LOC.
Often, in pulls for D, the LOC of the unittests exceeds the LOC of the fix.
I'm inordinately pleased with how well unittests have become embedded in our
D culture.
Yes, though I've had complaints before about a pull being too much code where
the unit tests were considered part of the code, and the reviewer thought that
number of lines was too great to be worth adding, even if the number of lines
of normal code was relatively small. And that sort of attitude would just lead
to not properly unit testing stuff.
I think it leads to writing less repetitive unittests.
If we did datetime all over again, I'd give a budget of 2000 lines for
all functionality. I bet the solution would be better.
Andrei
