On Wednesday, 8 May 2013 at 14:56:23 UTC, Benjamin Thaut wrote:
I recently got very disappointed by the review process of a
pull request I did on druntime:
https://github.com/D-Programming-Language/druntime/pull/370
This is how it went:
1) First everyone nitpicked about code formatting
2) I fixed all the nitpicks which was quite some work.
3) Pull request stalls for a month.
4) Even more nitpicks.
5) Even more work.
6) Reviewers actually start thinking about the problem behind
the pull request.
7) Problem is not important enough, review request gets
rejected.
8) All the work, including fixing nitpicks is wasted.
The timeliness of feedback is largely my fault. I hadn't been
spending much time on D last fall. This is something I intend to
change. For large changes like this though, I do think the
submitter needs to champion them if they want a timely review.
In most cases, if the change is an enhancement and it's as
substantial as this, people will put off reviewing it simply
because of the time required to do so.
