Go ahead then: don't let good code go wasted :)
My +1
Ciao,
R
Il giorno 21/feb/2012 21:02, "Simone Tripodi" <[email protected]> ha
scritto:
> Salut Olivier!
>
> I already proposed, some days ago - but looks like Daniel Manzke only
> took me seriously - an idea how to describe the configuration and the
> "factory".
>
> I invite you having a look at it if you didn't, because fits with what
> you described. Please see it on DIRECTMEMORY-62.
>
> Of course my proposal has to be enriched with regions, but I already
> have the impl on my machine.
>
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Tue, Feb 21, 2012 at 6:59 PM, Olivier Lamy <[email protected]> wrote:
> > Currently Solr test failed due to a chicken and eggs issue.
> >
> > private static CacheService cacheService = new CacheServiceImpl(
> > getMemoryManager() );
> >
> >
> > public static void init( int numberOfBuffers, int size, int
> > initialCapacity, int concurrencyLevel )
> > {
> > cacheService.init( numberOfBuffers, size, initialCapacity,
> > concurrencyLevel );
> > }
> >
> > public static MemoryManagerService getMemoryManager()
> > {
> > return cacheService.getMemoryManager();
> > }
> >
> > This Cache class is a bit confuse IMHO.
> > What is the purpose of this class exactly ? it looks to duplicate
> > CacheServiceImpl.
> >
> > I wonder about having like CacheFactory (or an other name) with a
> > DirectMemoryConfiguration class. I would prefer change the current
> > Cache class with that.
> >
> > class DirectMemoryConfiguration {
> > List<CacheRegion> cacheRegions;
> > }
> >
> > class CacheRegion {
> > String name;
> > int numberOfBuffers;
> > int size;
> > int initialCapacity;
> > int concurrencyLevel,
> > String memoryManagerClazz; // optionnal
> > }
> >
> > Basically this will instantiate a CacheServiceImpl per cacheRegion.
> >
> > BTW after we can talk about a configuration file mechanism.
> >
> > WDYT ?
> >
> > Lemme if that makes sense for you.
> >
> > --
> > Olivier Lamy
> > Talend: http://coders.talend.com
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
>
