Simone/Benoit After some review comments from Simone i have changed/refactored some of the work, have added two patches to https://issues.apache.org/jira/browse/DIRECTMEMORY-60
If you could possibly review and commit these in? Cheers Mike On 26 Feb 2012, at 01:25, Michael André Pearce wrote: > > > > On 26 Feb 2012, at 01:16, Simone Tripodi wrote: > >>> Its more about logical ownership, the logic/method of how to retrieve the >>> size in bytes is dependant on the underlying cache in our case >>> DirectMemory, the store should not need to have to have any logic or >>> understanding on how to calculate the size or capacity, it should just be >>> given it. If we can push these two methods to the core cache, then as with >>> below this could be removed until another need arises. >> >> so why not just extending the CacheServiceImpl? in that way we avoid >> unneeded boilerplate code. or, alternatively, if that methods could be >> useful also in other scenarios, move them directly in the >> CacheServiceImpl (and signature in the interface) > > +1 your feedback > > I think this one is probably best moved into CacheServiceImpl and we remove > the class, i think getting the total used space and avail capacity is a > generic feature people could take/use. > If you're in agreement, i can supply patches tomorrow for this. > >> >> best, >> -Simo >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi >> http://www.99soft.org/ >
