gemini-code-assist[bot] commented on code in PR #332:
URL: https://github.com/apache/tvm-ffi/pull/332#discussion_r2612120066
##########
python/tvm_ffi/cython/dtype.pxi:
##########
@@ -252,5 +252,5 @@ if numpy is not None:
cdef DLDataType cdtype = NUMPY_DTYPE_TO_DL_DATA_TYPE[numpy_dtype]
return make_dtype_from_dl_data_type(cdtype)
else:
- def _convert_torch_dtype_to_ffi_dtype(torch_dtype):
+ def _convert_numpy_dtype_to_ffi_dtype(numpy_dtype):
Review Comment:
While this change correctly fixes the function name, the error handling for
the missing `numpy` dependency could be improved. Raising an `ImportError` is
more idiomatic for missing packages, and a more descriptive error message would
be beneficial for the user. Consider changing the function body to:
```python
raise ImportError("numpy is not installed, which is required for numpy dtype
conversion.")
```
A similar improvement could be made for the `torch` check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
