gemini-code-assist[bot] commented on PR #18737: URL: https://github.com/apache/tvm/pull/18737#issuecomment-3869866667
## Summary of Changes Hello @mshr-h, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on reducing the maintenance burden and streamlining the CI infrastructure by completely removing support for the i386 and Hexagon architectures. This involves a comprehensive cleanup across configuration files, Jenkins pipeline definitions, Docker images, and test scripts, ensuring that the project's CI system is more focused and efficient. ### Highlights * **CI Pipeline Cleanup**: The continuous integration (CI) pipeline has been streamlined by removing support for the i386 and Hexagon architectures. * **Configuration Removal**: All references to i386 and Hexagon CI jobs, Docker images, and related build configurations have been purged from `.asf.yaml`, `ci/jenkins/data.py`, and `ci/jenkins/docker-images.ini`. * **Jenkinsfile Updates**: The generated Jenkinsfiles (`ci/jenkins/generated/*.groovy`) and their templates (`ci/jenkins/templates/*.j2`) have been updated to reflect the removal of i386 and Hexagon build and test steps, including the complete deletion of dedicated Jenkinsfiles for these platforms. * **Docker Image and Script Deletion**: The Dockerfiles (`docker/Dockerfile.ci_hexagon`, `docker/Dockerfile.ci_i386`) and associated Python integration scripts (`tests/scripts/task_python_integration_i386only.sh`) for i386 and Hexagon have been removed. * **Test Infrastructure Adjustments**: Tests related to i386 cross-compilation and x86 architecture checks have been updated to no longer include i386, ensuring the test suite aligns with the removed CI support. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **.asf.yaml** * Removed `hexagon/pr-head` and `i386/pr-head` from the GitHub CI configuration. * **ci/jenkins/data.py** * Removed `ci_hexagon` and `ci_i386` entries, which defined their Docker image tags and platforms. * **ci/jenkins/docker-images.ini** * Removed `ci_hexagon` and `ci_i386` entries, which specified their Docker image names. * **ci/jenkins/generated/arm_jenkinsfile.groovy** * Removed `ci_i386` and `ci_hexagon` variable declarations and related logic. * **ci/jenkins/generated/cpu_jenkinsfile.groovy** * Removed `ci_i386` and `ci_hexagon` variable declarations and related logic. * **ci/jenkins/generated/docker_jenkinsfile.groovy** * Removed `ci_i386` and `ci_hexagon` variable declarations and related logic, including deployment steps for these images. * **ci/jenkins/generated/gpu_jenkinsfile.groovy** * Removed `ci_i386` and `ci_hexagon` variable declarations and related logic. * **ci/jenkins/generated/hexagon_jenkinsfile.groovy** * Removed the entire generated Jenkinsfile for Hexagon. * **ci/jenkins/generated/i386_jenkinsfile.groovy** * Removed the entire generated Jenkinsfile for i386. * **ci/jenkins/generated/lint_jenkinsfile.groovy** * Removed `ci_i386` and `ci_hexagon` variable declarations and related logic. * **ci/jenkins/generated/wasm_jenkinsfile.groovy** * Removed `ci_i386` and `ci_hexagon` variable declarations and related logic. * **ci/jenkins/templates/hexagon_jenkinsfile.groovy.j2** * Removed the Jinja2 template for the Hexagon Jenkinsfile. * **ci/jenkins/templates/i386_jenkinsfile.groovy.j2** * Removed the Jinja2 template for the i386 Jenkinsfile. * **ci/jenkins/templates/utils/base.groovy.j2** * Removed `ci_i386` and `ci_hexagon` variable declarations. * **ci/scripts/github/github_tvmbot.py** * Removed `tvm-hexagon` and `tvm-i386` from the list of CI jobs that can be rerun by the bot. * **ci/scripts/github/update_branch.py** * Removed `hexagon/branch` and `i386/branch` from the list of expected CI jobs. * **docker/Dockerfile.ci_hexagon** * Removed the Dockerfile for Hexagon CI. * **docker/Dockerfile.ci_i386** * Removed the Dockerfile for i386 CI. * **docker/install/ubuntu_install_rust.sh** * Removed i386-specific host argument logic for rustup installation. * **tests/python/ci/test_ci.py** * Removed `ci_hexagon` and `ci_i386` from the list of Docker images checked in CI tests. * **tests/python/codegen/test_target_codegen_cross_llvm.py** * Removed the `build_i386` function and its invocation, eliminating i386 cross-compilation tests. * **tests/python/codegen/test_target_codegen_x86.py** * Modified the `pytest.skip` condition to no longer include `i386` machines, focusing solely on `x86_64`. * **tests/scripts/ci.py** * Removed `ci_i386` and `ci_hexagon` from the `DOCKER_IMAGES` set. * Removed the `i386` command generation from the CI script. * **tests/scripts/task_build.py** * Removed i386-specific build logic that used `make` instead of `cmake --build`. * **tests/scripts/task_python_integration_i386only.sh** * Removed this script entirely. </details> <details> <summary><b>Activity</b></summary> * The pull request was created by mshr-h. * The changes are part of a larger effort, as indicated by the reference to issue #18682. * Multiple Jenkinsfile generation timestamps were updated, suggesting a regeneration of CI configuration files after template modifications. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
