gemini-code-assist[bot] commented on code in PR #18737: URL: https://github.com/apache/tvm/pull/18737#discussion_r2781078739
########## docker/install/ubuntu_install_rust.sh: ########## @@ -21,14 +21,6 @@ set -euxo pipefail export RUSTUP_HOME=/opt/rust export CARGO_HOME=/opt/rust -# this rustc is one supported by the installed version of rust-sgx-sdk -HOST_ARG= -if [ "$(getconf LONG_BIT)" == "32" ]; then - # When building in the i386 docker image on a 64-bit host, rustup doesn't - # correctly detect the arch to install for so set it manually - HOST_ARG="--default-host i686-unknown-linux-gnu" -fi - # shellcheck disable=SC2086 # word splitting is intentional here curl -s -S -L https://sh.rustup.rs -sSf | sh -s -- -y --no-modify-path --profile minimal --default-toolchain stable $HOST_ARG Review Comment:  The `HOST_ARG` variable is used here, but it's no longer defined since the logic for setting it for i386 builds has been removed. This will cause the script to fail. Please remove `$HOST_ARG` from this command. ```suggestion curl -s -S -L https://sh.rustup.rs -sSf | sh -s -- -y --no-modify-path --profile minimal --default-toolchain stable ``` ########## ci/jenkins/generated/arm_jenkinsfile.groovy: ########## @@ -368,7 +362,7 @@ def prepare(node_type) { if (env.DETERMINE_DOCKER_IMAGES == 'yes') { sh( - script: "./${jenkins_scripts_root}/determine_docker_images.py ci_arm ci_cpu ci_gpu ci_hexagon ci_i386 ci_lint ci_wasm ", + script: "./${jenkins_scripts_root}/determine_docker_images.py ci_arm ci_cpu ci_gpu ci_lint ci_wasm ", Review Comment:  There's a trailing space in the script arguments. While it might not cause issues, it's better to remove it for cleanliness. This likely needs to be fixed in the template `ci/jenkins/templates/utils/base.groovy.j2` and will affect all generated Jenkinsfiles. ``` script: "./${jenkins_scripts_root}/determine_docker_images.py ci_arm ci_cpu ci_gpu ci_lint ci_wasm", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
