Thanks, building now Just one thing, shouldn't the xml files go into /gr-digital/grc/ like the other blocks instead of /gr-digital all by them selves?
Will get back to you on how it went. Best Paul 2011/10/26 Tom Rondeau <trondeau1...@gmail.com> > The master branch has been updated with the fixes to the GRC blocks. > > Thanks again for the reports! > > Tom > > > > > On Wed, Oct 26, 2011 at 7:55 AM, Tom Rondeau <trondeau1...@gmail.com>wrote: > >> On Wed, Oct 26, 2011 at 7:49 AM, Paul M. Bendixen <paulbendi...@gmail.com >> > wrote: >> >>> Did a little more digging >>> cd [gitdir]/grc/ >>> find . -name "*" | xargs grep digital >>> >>> Returns nothing, on the other hand grepping blks2.gmsk_mod returns: >>> ./Makefile.am: blks2_gmsk_mod.xml \ >>> ./block_tree.xml: <block>blks2_gmsk_mod</block> >>> ./blks2_gmsk_mod.xml: <key>blks2_gmsk_mod</key> >>> ./blks2_gmsk_mod.xml: <make>blks2.gmsk_mod( >>> >> >> >> Fixing these now. About to push the patch. >> >> >> >>> In other words: the XML structure of the grc that has to do with anything >>> moved to digital must be updated, before 3.5 can be compared to a stable >>> environment. >>> >>> XML has never been my strong suit, so I won't start looking into it. >>> Furthermore some of the blocks have changed input parameters (e.g. >>> gmsk_demod). >>> >>> Perhaps merging next into master was a little premature? >>> >>> Best regards >>> Paul >>> >> >> I don't think so at all. The problem is there are no automated test for >> this kind of stuff, and there's a lot of code that's of concern here. The >> only way we could get these kinds of error reports was to get the real users >> of GNU Radio to test them. These problems have been around in the old 'next' >> branch for a while, but without being used, there was no way for us to get >> these kinds of bug reports that is allowing us to fix them. >> >> In other words, I really appreciate you checking these things out and >> reporting the errors. This is also why we have stable releases. For people >> who have environments where stability is a concern, they should stick with >> the releases. >> >> I went through and checked the GRC blocks against everything I moved into >> gr-digital, so hopefully there is nothing left that I missed. I wonder if we >> can make a piece of automatic test code that would try to load each of the >> GRC XML blocks and report an error if it can't be loaded properly? >> >> Thanks! Let me know if you find anything else. >> >> Tom >> >> > -- * - - */* -/* * -/* - * */- * * */*/- */- * */* */- * * -/*/- */* - - *- */- - */- -/* -/* */* - * */* - * - * -/- * - */- - -/- -//
_______________________________________________ Discuss-gnuradio mailing list Discuss-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
