Thanks for you feedback and questions.

> The user might want to disable saving of evaluated params for size,
> security, etc. Would saving be optional?
>

Interesting idea. Shouldn't be too hard to implement - however I'd this
low-priority optional extension of the project.



> Some evaluated expressions could be huge, filter taps for instance, and
> can be readily regenerated. Should some things never be saved? Should some
> expressions be recognized as safe? Do we need to change the way we specify
> some params, e.g., don't use a Python expression in some places?
>

For non-primitive values only the repr used by the GUI will be stored.

We'll not try to be clever just to save a few of bytes. Read-only really
means no eval.

No changes to how flowgraphs are designed will be required.


> Many grc files, new and old, will not contain saved values. What will it
> look like when one of these files is opened?
>

Forward and backwards compatibility will be ensured. Users will be notified
if opening a flowgraph read-only is not possible



> Can expressions that are not evaluated be shown as a hover, the same way
> IDEs show references. Or some other way?
>

I read-only mode all expressions will use a cached value loaded from file.
Both the parameter dialog and optionallly blocks on the canvas can already
show expressions.


Sebastian



> On Fri, Jun 18, 2021 at 10:42 Oscar Ekholm <osc...@gmail.com> wrote:
>
>> Hello,
>>
>> A new Friday means a new *GSoC - View Only Mode* blog update! This time
>> it focuses on using the stored parameter values (from last week) instead of
>> evaluating the expressions. Read more about it on my blog:
>>
>> https://oscekh.github.io/
>>
>> Best regards,
>> Oscar Ekholm
>> <https://oscekh.github.io/>
>>
>> On Fri, Jun 11, 2021 at 5:24 PM Oscar Ekholm <osc...@gmail.com> wrote:
>>
>>> Hello everyone!
>>> I have now published the first blog post for my GSoC work on the GRC
>>> View-Only Mode. This week I have mainly worked at saving evaluated values
>>> of parameters in the grc-file. You can read about it here:
>>>
>>> https://oscekh.github.io/
>>>
>>> I will be posting an update on the blog each Friday, with a
>>> corresponding announcement on this list.
>>>
>>> Best regards,
>>> Oscar Ekholm
>>>
>>> On Mon, May 24, 2021 at 11:19 AM Oscar Ekholm <osc...@gmail.com> wrote:
>>>
>>>> Hello,
>>>>
>>>> I've been accepted to work with GnuRadio for this year's Google Summer
>>>> of Code. I will be working on implementing a GRC View-Only Mode, which is a
>>>> security feature disabling execution of block parameters in untrusted
>>>> flowgraphs.
>>>>
>>>> I will be posting weekly progress updates on my blog:
>>>> https://oscekh.github.io/
>>>>
>>>> If you are interested in reading more about the View-Only mode it is
>>>> described further in my project proposal:
>>>>
>>>> https://docs.google.com/document/d/1dL6PziJSopcY3O7gJ6CXiedTSdbhrHVFhR-UJRTmsng/edit?usp=sharing
>>>>
>>>> Please reach out if you have any questions, advice or thoughts you want
>>>> to share.
>>>>
>>>> Best regards,
>>>> Oscar Ekholm
>>>>
>>>

Reply via email to