Hi,

Thanks for the great feedback! My comments below...

bbuchs wrote:
> I would argue that "less is more". One of the most fantastic things about
> jQuery and the syntax is that it's so damn light. What's the most common
> scenario for a date picker in a web app? Is it really neccessary to pick a
> date 2, 3 years in the future?

Yeah - me too. I think that there are better ways to pick date a long
way in the future or a long way in the past (e.g. birthdays). So I'm not
going to do any changes to make selecting such dates easier...

> 
> Othewise, great plugin Kelvin. My only suggestions would be (1) to remove
> the extra markup and use a DOM creation method or a wrap() to add the
> container DIV, 

Good point. I had started to do this before but stopped for some reason!
It is now done.

> and (2) instead of doing INIT calls to use something more
> "jquery-esque":
> 
> $("input.mydate").datePicker({format:'mm/dd/yyyy', startdate:'08/15/2006',
> enddate:'08/31/2006'});

Yeah - this has come up a few times... I definitely think it looks much
nicer but had shied away from it because I thought it would add a lot of
complexity to the plugin to make it work where different date selects
had different start and end points. But it is a good improvement I think
so I have done it.

I have left format and language strings as globals because I can't
really see the use of having different date formats for different date
pickers on the same page - surely that would just be confusing? But I
totally see the point of having different selectable dates for different
date pickers so this is implemented.

> 
> But that's just me... Great work!
> 

Cheers - thanks for the feedback :)

The latest version is here:
http://kelvinluck.com/assets/jquery/datePicker/

Kelvin :)



_______________________________________________
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/

Reply via email to