On Tue, Oct 17, 2017 at 11:23 AM, Joerg Schilling < [email protected]> wrote:
> > Do you really support that a single person should be able to add code > without a > code review or after a code review did identify bugs? > Integration requires code review. One issue we do have is that we could do with more code reviewers. As a statistic, here is (roughly) the distribution of how many reviewers per commit. 0 12 1 483 2 1316 3 884 4 437 5 139 6 59 7 13 8 14 9 3 15 1 There's clearly a peak at 2-3 reviewers. I suspect that for many simple changes people see it's been reviewed and move on. (Of the 12 with no reviews, 10 are post-commit fixups, 1 is a typo in the commit message, only 1 [5524] appears to have no reviewers listed.) This would be really sad news. > > > Important should be that there is a need for a common repository that > > > includes > > > SVr4 package meta data, because otherwise only the IPS fans are > satisfied. > > This sounds only sensible in theory, as long as the meta data for SVR > > packages is enough to produce more package formats than just svr4, e.g. > > deb/rpm (if such a beast is needed) > > I know of no meta data that is missing in the SV package format. Even if > there > was something missing, we could easily add it as the format is open to > (even private) enhancements. > There's nothing missing from the IPS format either, and that's trivial to convert to other formats. It's just much easier to only maintain the metadata once. > The advantage of the format is that it supports a split / and /usr and > this is > something I do not like to miss for future options. > Split / and /usr is completely unrelated to packaging. (It's not a terribly good idea, but it's equally possible with any packaging system.) -- -Peter Tribble http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/ ------------------------------------------ illumos-discuss Archives: https://illumos.topicbox.com/groups/discuss/discussions/T784fc87098d66577-M25af43d2d917e6294744051f Powered by Topicbox: https://topicbox.com
