Hi Robert, Venkat, The patch is updated with the review comments, can you please review the same. https://git.opendaylight.org/gerrit/c/controller/+/108867
Thanks, Roshni From: Bentom Binoy <bentom.bi...@infosys.com> Sent: Tuesday, December 5, 2023 10:42 AM To: Roshni k k <roshni...@infosys.com>; Venkatrangan Govindarajan <gvran...@gmail.com>; Robert Varga <n...@hq.sk> Cc: discuss@lists.opendaylight.org; chandaluri_gupta <chandaluri_gu...@infosys.com>; Saravanan Shanmuga Sundaram <saravanan_...@infosys.com>; Sowndharya K <sowndhary...@infosys.com> Subject: RE: [ODL Discuss] ODL HA feature contribution: Requesting your view on outstanding HA defects for upcoming release. Hi Robert, We have removed all the testcases that has a dependency with DistributedDataStore.java. Can you please review the changes. Thanks & Regards, Bentom Binoy From: Roshni k k <roshni...@infosys.com<mailto:roshni...@infosys.com>> Sent: Tuesday, November 7, 2023 12:33 PM To: Venkatrangan Govindarajan <gvran...@gmail.com<mailto:gvran...@gmail.com>>; Robert Varga <n...@hq.sk<mailto:n...@hq.sk>>; Bentom Binoy <bentom.bi...@infosys.com<mailto:bentom.bi...@infosys.com>> Cc: discuss@lists.opendaylight.org<mailto:discuss@lists.opendaylight.org>; chandaluri_gupta <chandaluri_gu...@infosys.com<mailto:chandaluri_gu...@infosys.com>>; Saravanan Shanmuga Sundaram <saravanan_...@infosys.com<mailto:saravanan_...@infosys.com>>; Sowndharya K <sowndhary...@infosys.com<mailto:sowndhary...@infosys.com>> Subject: RE: [ODL Discuss] ODL HA feature contribution: Requesting your view on outstanding HA defects for upcoming release. Hi Venkat, @Bentom Binoy<mailto:bentom.bi...@infosys.com> has created a review request - https://git.opendaylight.org/gerrit/c/controller/+/108867 We haven’t deleted the deprecated code, but commented out the same. Also no changes were made in - opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java, opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TestDistributedDataStore.java Once the changes are reviewed and finalized, we can remove the commented code. Can you please review the changes. While building the code, few unit testcases failed. Tests run: 876, Failures: 7, Errors: 4, Skipped: 5 Please find a snapshot of the error logs. Error Logs ========= [ERROR] Failures: [ERROR] DatastoreContextContextPropertiesUpdaterTest.listenerTest:81 [ERROR] DatastoreContextIntrospectorTest.testGetDatastoreContextForShard:225 expected:<33> but was:<10> [ERROR] DatastoreContextIntrospectorTest.testUpdate:83 expected:<31> but was:<10> [ERROR] DatastoreContextIntrospectorTest.testUpdateWithDatastoreTypeSpecificProperties:197 expected:<33> but was:<10> [ERROR] DatastoreContextIntrospectorTest.testUpdateWithInvalidValues:161 updated [ERROR] DatastoreContextIntrospectorTest.testYangDefaults:48 expected:<1000> but was:<2> [ERROR] DistributedDataStoreRemotingIntegrationTest.testTransactionWithIsolatedLeader:1135 [ERROR] Errors: [ERROR] DistributedDataStoreIntegrationTest>AbstractDistributedDataStoreIntegrationTest.lambda$testSingleTransactionsWritesInQuickSuccession$0:276->AbstractDistributedDataStoreIntegrationTest.assertTellMetadata:298 » NoSuchElement [ERROR] DistributedDataStoreRemotingIntegrationTest.testLeadershipTransferOnShutdown:1071 » Timeout Waited 7 seconds (plus 167320 nanoseconds delay) for SettableFuture@509ae2c8[status=PENDING] [ERROR] DistributedDataStoreRemotingIntegrationTest.lambda$testSingleTransactionsWritesInQuickSuccession$1:387->assertTellClientMetadata:407 » NoSuchElement [ERROR] DistributedDataStoreWithSegmentedJournalIntegrationTest>AbstractDistributedDataStoreIntegrationTest.lambda$testSingleTransactionsWritesInQuickSuccession$0:276->AbstractDistributedDataStoreIntegrationTest.assertTellMetadata:298 » NoSuchElement Thanks, Roshni From: Roshni k k Sent: Friday, November 3, 2023 8:17 PM To: Venkatrangan Govindarajan <gvran...@gmail.com<mailto:gvran...@gmail.com>>; Robert Varga <n...@hq.sk<mailto:n...@hq.sk>> Cc: discuss@lists.opendaylight.org<mailto:discuss@lists.opendaylight.org>; chandaluri_gupta <chandaluri_gu...@infosys.com<mailto:chandaluri_gu...@infosys.com>>; Saravanan Shanmuga Sundaram <saravanan_...@infosys.com<mailto:saravanan_...@infosys.com>>; Bentom Binoy <bentom.bi...@infosys.com<mailto:bentom.bi...@infosys.com>>; Sowndharya K <sowndhary...@infosys.com<mailto:sowndhary...@infosys.com>> Subject: RE: [ODL Discuss] ODL HA feature contribution: Requesting your view on outstanding HA defects for upcoming release. Hi Venkat, Yes we are working on https://jira.opendaylight.org/browse/CONTROLLER-2054 We have made the code changes based on the gerrit review - https://git.opendaylight.org/gerrit/c/controller/+/103103 As per the above review, * The class DistributedDataStore defined in opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java is deprecated and we have moved out this java file * The class TestDistributedDataStore opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TestDistributedDataStore.java is deprecated and we have moved out this java file. If we move out these files we are encountering compilation failure. Are we supposed to delete the above files? Can you pls share your views on this. We can create a gerrit review for the changes we made and share the details. Thanks, Roshni From: Venkatrangan Govindarajan <gvran...@gmail.com<mailto:gvran...@gmail.com>> Sent: Friday, November 3, 2023 10:49 AM To: Robert Varga <n...@hq.sk<mailto:n...@hq.sk>> Cc: Roshni k k <roshni...@infosys.com<mailto:roshni...@infosys.com>>; discuss@lists.opendaylight.org<mailto:discuss@lists.opendaylight.org>; chandaluri_gupta <chandaluri_gu...@infosys.com<mailto:chandaluri_gu...@infosys.com>>; Saravanan Shanmuga Sundaram <saravanan_...@infosys.com<mailto:saravanan_...@infosys.com>>; Rohini Ambika <rohini.amb...@infosys.com<mailto:rohini.amb...@infosys.com>> Subject: Re: [ODL Discuss] ODL HA feature contribution: Requesting your view on outstanding HA defects for upcoming release. [**EXTERNAL EMAIL**] Hi Roshni, Are you trying to address https://jira.opendaylight.org/browse/CONTROLLER-2054. We are interested in removing ask from AbstractShardBackendResolver Are you facing an issue with the same? வியா., 7 செப்., 2023, முற்பகல் 4:21 அன்று, Robert Varga <n...@hq.sk<mailto:n...@hq.sk>> எழுதியது: On 21/08/2023 09.18, Roshni k k via lists.opendaylight.org<http://lists.opendaylight.org/> wrote: > Hello Robert and All, Hello Roshni, welcome in our little community :) > 1. I recently started joining ODL Linux Networking Community along with > my colleagues @Saravanan Shanmuga Sundaram > <mailto:saravanan_...@infosys.com<mailto:saravanan_...@infosys.com>> and > @Rohini Ambika > <mailto:rohini.amb...@infosys.com<mailto:rohini.amb...@infosys.com>> . > 2. We have experience in Java and SDN Technologies and we are > interested in contributing to ODL in high availability/clustering area. Cool, glad to meet you. > 3. In this regard I have pulled JIRA issues related to clustering. > Some of these tickets are bit older I would like to get your > opinion/review on these tickets so that I can start working on them. Yeah, we have all sorts of these. Unfortunately there is some disrepair, as we do not have full-time contributors in this area, I am afraid. > 4. Meanwhile we have setup a local ODL environment with 3 node cluster > with Chlorine SR1. My plan is to validate the older defects if they > still exists in the latest release. Awesome, this is very welcome work! > 5. Please let us know if you have any recommended tickets that can be > picked up under the clustering area for the upcoming release. I am not tracking anything overly critical. Everything in CONTROLLER is up for grabs, most notably the things we do not have steps to reproduce or have not been confirmed. In clustering, the usual thing after having steps to reproduce was to create a reproducer unit test first and then zero in on the fix. Tom Pantelis used to use this approach to shake out some really terrifying things :) Also, we have a weekly call which noone is using, where we discuss things that need doing in kernel projects. If you have details to discuss, we can just up that... Regards, Robert -- Venkatrangan Govindarajan ( When there is no wind...Row ) -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9055): https://lists.opendaylight.org/g/Discuss/message/9055 Mute This Topic: https://lists.opendaylight.org/mt/100868720/21656 Group Owner: discuss+ow...@lists.opendaylight.org Unsubscribe: https://lists.opendaylight.org/g/Discuss/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
