On  2 Mar 2006, Dan Kegel <[EMAIL PROTECTED]> wrote:
> On 3/2/06, Martin Pool <[EMAIL PROTECTED]> wrote:
> > I think there is a bug in the select-for-write loop that Dan added to
> > dcc_connect_by_addr:
> 
> The loop is visible here, for those following along at home:
> http://archzoom.sourcecontrol.net/archzoom.cgi/[EMAIL 
> PROTECTED]/distcc--devel--2--patch-170/src/clinet.c
> 
> > Perhaps that check should be hoisted out of the loop.
> 
> Yeah, the first check in the loop (the one that checks for EINPROGRESS)
> clearly should be outside the loop - it's there to check for immediate connect
> errors.  Also, 'failed' never changes inside the loop.

OK fixed in arch.
-- 
Martin

Attachment: signature.asc
Description: Digital signature

__ 
distcc mailing list            http://distcc.samba.org/
To unsubscribe or change options: 
https://lists.samba.org/mailman/listinfo/distcc

Reply via email to