At 09:20 AM 10/6/2009 +0300, Alex Grönholm wrote:
P.J. Eby kirjoitti:
At 11:53 AM 10/5/2009 +0200, Lennart Regebro wrote:
2009/10/5 Jeff Rush <j...@taupro.com>:
> Very unfortunate, as in, it should NOT have happened. And *especially*
> without any announcement on python.org or mention on the
> python-committers list of something this major.
Well "this major"... It's a bug fix that breaks a setuptools monkey-patch.
Subclassing distutils commands != monkeypatching. If, say, numpy's
distutils extensions subclass build_ext and override that method,
they could have had the same problem. Same for anybody else's
distutils extensions.
Setuptools subclasses distutils commands and then replaces the
original classes with its own.
Example from setuptools/__init__.py:
import distutils.core
distutils.core.Command = Command
Isn't this exactly what monkey patching means?
Yes, but that's got nothing to do with the bug that's been being
discussed. The same change bit pywin32, and it doesn't use setuptools at all.
_______________________________________________
Distutils-SIG maillist - Distutils-SIG@python.org
http://mail.python.org/mailman/listinfo/distutils-sig
