To be clear, is everyone okay with the following? build_wheel(wheel_directory, config_settings=None, metadata_directory=None): [REQUIRED] build_wheel_incremental(wheel_directory, config_settings=None, metadata_directory=None): [OPTIONAL]
I still think that the frontend should not provide a build_directory, but if someone *really* wants the build_directory in the incremental function, then I will "disagree and commit." 2017-08-24 13:13 GMT-05:00 Thomas Kluyver <tho...@kluyver.me.uk>: > On Thu, Aug 24, 2017, at 06:20 PM, Daniel Holth wrote: > > On Thu, Aug 24, 2017 at 12:34 PM Thomas Kluyver <tho...@kluyver.me.uk> > wrote: > > Is there a reason to ask for an 'unclean' build, though? There may be a > performance optimisation from reusing cached data, > > > For the same reason you would ever ask for incremental builds, to more > quickly iterate while hacking, imagining that you are using the PEP 517 > interface to develop, perhaps to have a uniform interface to patch > something when you are not familiar with exactly the build system it uses. > > > Yup, this is what I meant about using cached data for performance. But I > don't think this requires builds to modify the source directory. The build > system can cache data elsewhere on the filesystem, whether or not it's > given an explicit build_directory. > > I think we can specify one kind of build that is both 'clean' (doesn't > modify the source directory) and incremental (can use cached data to speed > up the build). If that's workable, it seems like it would save a lot of > headaches rather than trying to specify them as two different options. > > We have explicitly excluded editable installs (i.e. inplace builds) from > this PEP, though we can add a hook for that in a later PEP. I agree with > you that this PEP should allow for fast incremental (but non-inplace) > builds if possible, though. > > Thomas > > _______________________________________________ > Distutils-SIG maillist - Distutils-SIG@python.org > https://mail.python.org/mailman/listinfo/distutils-sig > >
_______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org https://mail.python.org/mailman/listinfo/distutils-sig