Thanks, Paulo, and I'm sorry, this was my fault. My app was indeed using
has_page_change_permission(). It wasn't a problem with django-cms. Another
change in django-cms caused the exception in my app to change to something
else, but ultimately I resolved my problems by removing usage of
has_page_change_permission() and fixing usage of remove features
(cms_app.py to cms_apps.py and cms_toolbar.py to cms_toolbars.py).
One possible improvement for django-cms could be the release notes
regarding how to upgrade for the permissions changes:
http://docs.django-cms.org/en/latest/upgrade/3.4.html#permissions
I've attached a diff of the change I made to my app and maybe you can tell
me if it's correct. In particular, I couldn't tell the reason for both the
Page.has_change_permission() method and the
cms.utils.page_permissions.user_can_change_page() function. Since the
former calls the latter, I can't see why the latter is needed.
page.has_change_permission(self.request.user)
seems simpler to me than (equivalent I think):
page_permissions.user_can_change_page(request.user, page=page)
Thanks!
On Friday, September 2, 2016 at 8:19:08 AM UTC-4, czpython wrote:
>
> Hello Tim,
>
> Sorry for trouble.
> Following Django practices, we've started to only do *one* commit per PR
> which means that we no longer have a change with commits that work and
> others that don't.
> The big "Bumped version to 3.4.0rc1" commit contains release *only*
> changes like PO file changes from Transifex, compilemessages, etc.. it's
> why it shows as 5k lines +.
>
> Regarding the ImportError cannot import name 'has_page_change_permission'
> error, this is caused by our refactor of the permissions logic.
> has_page_change_permission was not a public API and as such got removed
> without a deprecation period, you can see the list of functions that were
> removed in the release notes
> <http://docs.django-cms.org/en/latest/upgrade/3.4.html#permissions>.
>
> Most of the functions there were replaced by more specific functions in
> cms.utils.page_permissions, if you still rely on the CMS permissions system
> feel free to ping me to get more information
> on the new API. Like the old one, it's still private but now it's very
> unlikely to change for a bit.
>
>
> On Thursday, September 1, 2016 at 9:41:08 PM UTC-4, Tim Graham wrote:
>>
>> Hi,
>>
>> I wanted to share my experience trying to update to django-cms 3.4. When
>> I launch my app, I get a NoReverseMatch exception related to URL reversing,
>> so I tried to use git bisect to find the commit where the behavior changed
>> in the django-cms. This wasn't so pleasant as there were a long string of
>> commits where I couldn't run my app due to "ImportError cannot import name
>> 'has_page_change_permission'" coming from django-cms. It seems that
>> django-cms may be broken in its history for quite a few commits (maybe
>> during the massive "Bumped version to 3.4.0rc1" merge commit?) which makes
>> it quite difficult to pin exactly why my app is failing. I'm not sure if
>> this is a common issue anyone else has seen or if it could have been
>> avoided, but I just wanted to emphasize that it's really helpful if
>> django-cms is working after each commit to help in a case like this. I'll
>> admit that I don't really understand how git merging works but I find
>> Django's cherry picking of commits to make backports to be very reliable in
>> terms of making history bisectable. Anyway, just wanted to share in case
>> some process improvement could come of it. I'll try to debug the actual
>> problem with my app later.
>>
>>
>> There are only skipped commits left to test.
>> The first bad commit could be any of:
>> 035de0310f54ed4b2ddacf9bd715c3ab4e9de072
>> 046dc3e937b18a4f16526257320aa25a7a143754
>> 1c92e02c8bfaba544663c91c6d7efa30e40e0de0
>> 70a5c61500d7d3c7f09f7844bb64db4beeff7a7c
>> 4989c294bc21dd725690983a0034300d5c1770e5
>> f96c80357c7152ef46045842ad0edb9b27dddae7
>> 0136232ded0b97605d88df3da0f42a7fa13fcda5
>> bc1ae40a84592436ef56ac93a21e3f5320324174
>> 59d303bb0b07beecbbe3f18a2498e382d6022430
>> 8e2e049eaaf85b01a1e1949ce6dec6366fca577e
>> 153b3d5625117769354918fb28ae73c48b417a4d
>> c6e7ccd9c1e8fab5bc257abb6d9e6b268fb93f9a
>> c7617f3150e3fddc37ed2345aa2d38b6f0956ee1
>> 365e503f7e21e924cfae13bf7a0f8364b2e98d4c
>> db2b69ba800033515aa8cdf907895cb7d7fb19be
>> aabeb755ee6d711f403370f1b4149b3de2e985fc
>> 355b7671b60a43b53f60ff3f23be57f460e920b2
>> 4fd0d66ecdc44fa081b1d19e8550320a00b59b76
>> a4c0cb5d99bee250b6f0c6e33f50503a8248ef7c
>> d41b42316ebacb236ca116a4b2aa324291da673e
>> e686f74542b08757a8c996df034909d158573780
>> 08c51d30a00727fae9c47ba650cb088e7646f47b
>> 9b4af053b1f3d90e52d4c054b83682aef05c57d2
>> af21e0c352df6a07d98587c1e8a31f072a6a43e8
>> 16e3bbecb7c9bf5d77c56e49832f473b177de6cf
>> 5c09f1d731aa644fb091941654a37843ff9eab7a
>> b4ca4580aaa7531644ccc6661614d21417d3ee7b
>> We cannot bisect more!
>>
>>
--
Message URL:
https://groups.google.com/d/msg/django-cms-developers/topic-id/message-id
Unsubscribe: send a message to
django-cms-developers+unsubscr...@googlegroups.com
---
You received this message because you are subscribed to the Google Groups
"django CMS developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-cms-developers+unsubscr...@googlegroups.com.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/django-cms-developers/6acd9a43-0444-44fb-8fbb-3a3366eae425%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
diff --git a/page_extensions/cms_toolbars.py b/page_extensions/cms_toolbars.py
index f709396..d58f168 100644
--- a/page_extensions/cms_toolbars.py
+++ b/page_extensions/cms_toolbars.py
@@ -1,8 +1,6 @@
from cms.api import get_page_draft
from cms.toolbar_base import CMSToolbar
from cms.toolbar_pool import toolbar_pool
-from cms.utils import get_cms_setting
-from cms.utils.permissions import has_page_change_permission
from django.core.urlresolvers import NoReverseMatch, reverse
from django.utils.translation import ugettext_lazy as _
@@ -19,16 +17,12 @@ class HeaderImageExtensionToolbar(CMSToolbar):
# Nothing to do
return
- # check global permissions if CMS_PERMISSIONS is active
- if get_cms_setting('PERMISSION'):
- has_global_current_page_change_permission = has_page_change_permission(self.request)
- else:
- has_global_current_page_change_permission = False
- # check if user has page edit permission
+ # check if user has page edit permission
can_change = (
self.request.current_page and
- self.request.current_page.has_change_permission(self.request))
- if has_global_current_page_change_permission or can_change:
+ self.request.current_page.has_change_permission(self.request.user)
+ )
+ if can_change:
try:
header_image = HeaderImage.objects.get(extended_object_id=self.page.id)
except HeaderImage.DoesNotExist:
