Hi,
in changeset 4208 all the code from django/forms was copied to
django/oldforms. Isn't that a little bit twisted? Now there's the
same code twice, and any future patch for forms needs to address
both trees.
This may not be a big problem for the core development of django,
but I guess there are a few people here who will rely on oldforms
for some time, and sooner or later there will be bug fixes. And,
this bites anybody who uses patches for forms, and these patch
the django/forms tree and not oldforms (it got me today, since I
merge with the django trunk weekly).
These patches apply cleanly to the django/forms tree (since it's
still there), but as soon as you import oldforms instead of
forms, the patches are inactive since they only modify the forms
tree. Anyway, code duplication is simply waiting for strange
accidents to take place.
Would it instead be possible to remove django/forms completely,
and add this line in django/__init__.py:
{{{
import oldforms as forms
}}}
Then any patch that refers to forms will simply fail to apply,
making obvious that it needs to be adapted.
Perhaps it makes more sense to undo changeset 4208 completely and
then make a rename instead of a copy. This might help with
subversion for merging branches. I can't say for certtain since
I've used git for too long, perhaps someone more experienced with
svn can comment on this.
Michael
--
noris network AG - Deutschherrnstraße 15-19 - D-90429 Nürnberg -
Tel +49-911-9352-0 - Fax +49-911-9352-100
http://www.noris.de - The IT-Outsourcing Company
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---
