Markdown 1.7, released February 17, 2008, has a backwards-incompatible change.

"
Additionally, the encoding argument has been removed from both
markdown and Markdown. Markdown expects unicode (or ascii) input and
it is the users responsibility to ensure that's what is provided.
"

The current django filter[1] passes the results of smart_str, which is
explicitly a byte-string, defaulting to utf-8.

I think there should be a branch checking the markdown version, and
passing in a unicode object if  markdown.version_info >= (1,7,0,'').

Also, and probably more important: markdown allows HTML to be passed
in and spit out; the markdown filter marks output as safe.  Is it an
intended design choice to have applying the markdown filter result in
unescaped output?  Perhaps this side-effect should be noted in the
docs[2]?

[1]
http://code.djangoproject.com/browser/django/trunk/django/contrib/markup/templatetags/markup.py#L35

[2]
 http://www.djangoproject.com/documentation/add_ons/#markup

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to