On Thu, Jul 3, 2008 at 12:22 PM, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > I just talked about this with Mike on IRC; I think chunk() is > non-obvious and we're gonna change it to chunks(). Hopefully nobody's > written so much code in the last week to be pissed. > > Also, we're going to change UploadedFile.file_name to > UploadedFile.name to more closely match the built-in file API. > > Sorry about not thinking this through fully before committing, but > it's gonna be better this way.
Well, as long as the floor's open, I'd like to make sure file storage code is consistent. Currently, it uses filename instead of file_name or just name, and it also uses size instead of file_size. I assume I should go with name instead of filename, but should I use file_size, or should the upload stuff use size? On a related note, when merging #5361 with the new trunk, should the file-related code, such as moving files and whatnot, be moved into django.core.filestorage.filesystem? Also, should the code in django.core.filestorage be moved over to the new django.core.files package instead? So many bikesheds, so little time. -Gul --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
