Ah no problems! As there aren't any tests for the staff_member_required or even request.get_full_path() I wasn't 100% sure what the procedure would be as these are used through out Django.
As it's such a minor change does it warrant the bureaucracy of requiring tests to have it implemented? I think definitely there should be a ticket opened to ensure that tests are written to test the logic staff_member_required and request.get_full_path(). At the moment I'm not sure where they would fit. Happy to help either way. Ross On Jul 18, 9:04 am, "Russell Keith-Magee" <[EMAIL PROTECTED]> wrote: > On Fri, Jul 18, 2008 at 3:57 PM, Rozza <[EMAIL PROTECTED]> wrote: > > > Hi all, > > > This is a bump for ticket #5801 it was marked as accepted back in > > February but has not yet been applied! > > > Apologies if this is against protocol - it just seems this simple > > patch has been lost amongst the many! > > If you look at the triage process [1], you will see that there is a > good reason that the patch hasn't been applied. Accepted means that we > acknowledge that the bug is real, not that the patch is ready. A patch > will only be applied when the ticket has been marked ready for > checkin. > > The obvious reason for this ticket not being ready for checkin is that > the patch doesn't have any tests. This should be a relatively simple > case to check with the built in test client, so there is no excuse for > not having tests. Write some tests, and we'll get this ticket > committed. > > [1]http://www.djangoproject.com/documentation/contributing/#ticket-triage > > Yours, > Russ Magee %-) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
