Could always use the super hacky "check the ImportError message for
the name of the admin module" to decide whether to reraise the error
or not.

On Oct 22, 11:37 pm, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
wrote:
> Waylan, while discussing this with Clint, I came to the conclusion
> that we will still face this problem with this solution.  However,
> IMO, that is indicative of an upstream problem and should be reported
> up stream, once it is fixed there this solution will continue to work
> correctly for both regular modules and eggs.
>
> Alex
>
> On Oct 23, 12:20 am, "Waylan Limberg" <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Oct 22, 2008 at 7:16 PM, Clint Ecker <[EMAIL PROTECTED]> wrote:
>
> > > Hi all,
> > >   I've opened a ticket on this matter (http://code.djangoproject.com/
> > > ticket/9427) but the gist of it is this:
>
> > [snip]
>
> > > I'm throwing this out there just to get a wider eye on the patch just
> > > in case there are any edge cases that these changes might affect.
>
> > What about an admin.py in an egg that legitimately raises an error on
> > import? If imp.find_module can't find it as you claim, won't that
> > error be eaten? Now, I realize that should probably be caught while
> > testing not in an egg first, but it is a real possibility. Perhaps we
> > shouldn't care about that one though.
>
> > --
> > ----
> > Waylan Limberg
> > [EMAIL PROTECTED]

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to