On Sun, Apr 5, 2009 at 11:33 AM, Dan Tallis <[email protected]> wrote:
> > Prior to 10206, the formset is_valid returned False and the user saw > the error messages as I intended. From 10206 on, the formset is_valid > returns True (because validation errors on forms marked for deletion > "don't count") and so my view goes on to try to save the forms. > > So, is this an unintended consequence? If so, please can it be backed > out pending further design discussion? > We can't really have it both ways. Either validation errors on a form stop deletion, or they don't. (Or there's a way to choose one or the other per formset, but I'd like to avoid that.) The new behavior is more correct in my view, and there should be a more specific way to veto deletion, but there's no way to do that without making people who rely on the pre-10206 implementation write more code. That said, I'm inclined to back it out for the 1.1 release. This has bitten at least one other person that I know of, and it wasn't in the beta, so it will likely bite others who aren't tracking trunk. Joseph --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
