It's not clear to me from the thread so far whether there has been a
decision to back out 10206, but, to add some more evidence, I would
point out that it has also made it rather more awkward to process
formsets: You can no longer iterate over form.formsets (e.g. in a save
method) and consider cleaned_data, since it might not be present.
Unless I've missed something, there's deleted_forms, but no analogous
non_deleted_forms (which would help, but may still require quite a lot
of applications to change their approach).

Also the documentation [1] includes code that will no longer work in general:

>>> [form.cleaned_data for form in formset.deleted_forms]

(may fail because form.cleaned_data will not be present if the form
had 'delete' set but other field-level validation errors).

Thinking about possible ways forward, one observation that occurs to
me is that I think there's a significant semantic distinction between
field validation and form-level (non-field) validation that applies in
this case:  Field validation errors on forms with delete should not
cause formset is_valid to return False but perhaps form-level errors
should...?

Regards

Dan

[1] 
http://docs.djangoproject.com/en/dev/topics/forms/formsets/#dealing-with-ordering-and-deletion-of-forms

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to