Oops, looks like I used the wrong git diff command and it didn't include any new files. I'll have a stab at the depreciation warnings too.
Ben On 20 Dec 2009, at 02:49, Jacob Kaplan-Moss wrote: > On Sat, Dec 19, 2009 at 8:33 AM, Jacob Kaplan-Moss <[email protected]> wrote: >> Code-wise, though, everything looks fine. Don't worry too much about >> getting to all the formal stuff: I'll probably be committing this >> today. > > Or not. There's a failing test in your patch:: > > ====================================================================== > FAIL: test_template_feed > (regressiontests.syndication.tests.SyndicationFeedTest) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/Users/jacob/Projects/Django/upstream/tests/regressiontests/syndication/tests.py", > line 247, in test_template_feed > 'link': 'http://example.com/blog/1/', > File > "/Users/jacob/Projects/Django/upstream/tests/regressiontests/syndication/tests.py", > line 25, in assertChildNodeContent > elem.getElementsByTagName(k)[0].firstChild.wholeText, v) > AssertionError: u'Overridden description: My first entry' != > 'Description in your templates: My first entry' > > ---------------------------------------------------------------------- > > ... and I've not yet been able to figure out what's going on. Looks > like I won't have a chance to check it in before I leave for vacation > tomorrow. > > However, I'm +1 on the way you've done this, and would very much like > to see it get in. So any other committers should feel free to commit > this assuming Ben can track down and fix the bug. > > Jacob > > [Failing that, I'll probably stretch the definition of "minor feature" > a bit and plan to commit this for the beta instead...] > > -- > > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
