Hello, I have finished the changes. You can get the latest patch and list of updates on the ticket page [1]. All tests run without an error and the patch is ready for commit. I think somebody else should change the status of the ticket according to our discussion here.
Thank you Ekrem and Russel, for your review and comments. [1] http://code.djangoproject.com/ticket/14563 Best regards, Serkan Kenar On Fri, Oct 29, 2010 at 3:04 PM, Serkan Kenar <serkanke...@gmail.com> wrote: > Hello Ekrem, > > Thanks for the review. > > On Fri, Oct 29, 2010 at 2:39 PM, Ekrem SEREN <ekrem.se...@gmail.com>wrote: > >> 3) Does the postal code field accurately capture all possible Turkish >>> postal codes? >>> >> >> I believe it does. I don't know any condition about postal codes other >> than they should be 5 digits. >> > > As I said earlier, I'll add the province code check for the first two > digits. The complete list can be downloaded from the Turkish Post Office's > web site, there is no exception to this rule. (5-digits, first two are > province code). > >> >> >>> 4) Does the phone number field accurately capture all possible >>> Turkish phone numbers? >>> >> >> It does. But I think it would be better to get them corrected to >> XXXXXXXXXX (10 digits long, no spaces, first 3 digits are area code and the >> rest is phone number) instead of 0XXX XXXXXXX. >> > >> Leading "0" is an area code and there is no need to save it to database. >> If neccessary someone could write a filter to render it any way he likes. >> > > You're right, I guess that's is better. I'll fix this too, together with > the tests. > > Best regards, > > -- > Serkan Kenar > -- Serkan Kenar -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
