On 18.06.2011, at 03:38, Stephen Burrows wrote:

> I would love it if someone could look at 13956 [1]
> 
> [1] http://code.djangoproject.com/ticket/13956

I'd like to repeat my concerns from the ticket that it seems odd to extend the
helper tags with support for *args but leaving out **kwargs. If the API of
those tags should be extended with concepts from Python we shouldn't do this
only partially.

Fortunately there is a good (new) convention in Django how to write kwarg
style template parameters, thanks to Chris Beaven's with/include tag refactor
(``{% with arg1=1 arg2=2 %}{{ arg1 }}: {{ args2 }}{% endwith %}``), which
could also be used for the tag helpers.

Jannis

> On Jun 7, 12:24 pm, Carl Meyer <c...@oddbird.net> wrote:
>> Hi Stephen,
>> 
>> On 06/07/2011 02:37 AM, Stephen Burrows wrote:
>> 
>>> Hi - is the 5-for-1 deal still active on ticket reviews? [1]
>>> If so, I've reviewed the following tickets:
>> 
>>> 3624
>>> 16152
>>> 16157
>>> 16158
>>> 16166
>> 
>>> And would love it if someone could have a look at ticket 14082 [2].
>> 
>>> If not, ah well. :-)
>> 
>> Thanks for the ticket reviews, and your work on the patch. Committed in
>> r16334 [1]
>> 
>> Carl
>> 
>>   [1]https://code.djangoproject.com/changeset/16334
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to 
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at 
> http://groups.google.com/group/django-developers?hl=en.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to