Thanks for having a look at the ticket. I'd be happy to rewrite the
patch to include **kwargs support, if that's what people want.
However, there's no precedent in django for a tag accepting args *and*
kwargs (that I am aware of.) What would the syntax look like?
{% simple_tag arg1 arg2 with hi="low" foo="bar" %}?
{% simple_tag with arg1 arg2 hi="low" foo="bar" %}?
{% simple_tag arg1 arg2 hi="low" foo="bar" %}?
@Sam Bull: Looking at fancy_tag, I think that turning it into a patch
might be as much or more work than just converting the current patch
to also support kwargs.
On Jun 18, 10:12 am, Sam Bull <osir...@gmail.com> wrote:
> Hey,
>
> I've got a reusable app that offers the functionality you're looking for, I
> think. I just commented on the ticket, so I hope this doesn't count as
> double-posting, but you can check it out
> here:https://github.com/trapeze/fancy_tag
>
> It's got unit tests, keyword argument support (like the new with tag), *args
> support, **kwargs support, and support for the "with <varname>" pattern.
>
> Is this something I should convert into a patch?
>
> Sam
>
> On 2011-06-18, at 5:29 AM, Jannis Leidel wrote:
>
>
>
>
>
>
>
> > On 18.06.2011, at 03:38, Stephen Burrows wrote:
>
> >> I would love it if someone could look at 13956 [1]
>
> >> [1]http://code.djangoproject.com/ticket/13956
>
> > I'd like to repeat my concerns from the ticket that it seems odd to extend
> > the
> > helper tags with support for *args but leaving out **kwargs. If the API of
> > those tags should be extended with concepts from Python we shouldn't do this
> > only partially.
>
> > Fortunately there is a good (new) convention in Django how to write kwarg
> > style template parameters, thanks to Chris Beaven's with/include tag
> > refactor
> > (``{% with arg1=1 arg2=2 %}{{ arg1 }}: {{ args2 }}{% endwith %}``), which
> > could also be used for the tag helpers.
>
> > Jannis
>
> >> On Jun 7, 12:24 pm, Carl Meyer <c...@oddbird.net> wrote:
> >>> Hi Stephen,
>
> >>> On 06/07/2011 02:37 AM, Stephen Burrows wrote:
>
> >>>> Hi - is the 5-for-1 deal still active on ticket reviews? [1]
> >>>> If so, I've reviewed the following tickets:
>
> >>>> 3624
> >>>> 16152
> >>>> 16157
> >>>> 16158
> >>>> 16166
>
> >>>> And would love it if someone could have a look at ticket 14082 [2].
>
> >>>> If not, ah well. :-)
>
> >>> Thanks for the ticket reviews, and your work on the patch. Committed in
> >>> r16334 [1]
>
> >>> Carl
>
> >>> [1]https://code.djangoproject.com/changeset/16334
>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "Django developers" group.
> >> To post to this group, send email to django-developers@googlegroups.com.
> >> To unsubscribe from this group, send email to
> >> django-developers+unsubscr...@googlegroups.com.
> >> For more options, visit this group
> >> athttp://groups.google.com/group/django-developers?hl=en.
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Django developers" group.
> > To post to this group, send email to django-developers@googlegroups.com.
> > To unsubscribe from this group, send email to
> > django-developers+unsubscr...@googlegroups.com.
> > For more options, visit this group
> > athttp://groups.google.com/group/django-developers?hl=en.
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
