On 3 déc. 2011, at 23:36, Jonas H. wrote:
> On Jacob's suggestion in this thread [1] back in April, I split the diff 
> between Django trunk and Django-nonrel into logically separated patches.
> 
> I uploaded most of them to the ticket tracker (a few things are still missing 
> but these are the most important changes):

Hi Jonas,

I just came across your patches while I was triaging the "unreviewed" queue. 
Unfortunately, I found it difficult to assess them, since they don't include 
tests or docs.

Generally, all changes should come with tests. If you're adding new features — 
for instance "Support for non-integer primary keys" sounds an interesting one — 
those should be documented too.

That would help people who aren't familiar with django-nonrel (like me) to 
review your patches, and in particular to understand their consequences.

That said, I believe NoSQL support in a very interesting experiment for 
Django's ORM, and I really hope we can move forward with these tickets!

Best regards,

-- 
Aymeric.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to