-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi,
On 02/11/2012 10:13 AM, j4nu5 wrote: > I have written a patch for ticket #16304 (https:// > code.djangoproject.com/ticket/16304). Thanks for the patch. > The ticket adds support for the HTML5 input placeholder attribute > (WHAT Working Group placeholder description - > http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-placeholder-attribute), > in Forms as well as ModelForms. I agree with the previous commenter that HTML widget attributes do not belong in model field definitions. Making it possible to achieve arbitrary modifications to ModelForm output HTML without ever overriding a widget in the ModelForm is a bad design goal; there's a reason the ModelForm (and widgets) exist as an intermediary layer. > I was wondering if a larger undertaking can be taken to make Django > HTML5 aware. Options may include support for new input types like tel, > email etc. which currently are rendered simply as text and ModelForms/ > Forms have to manually override widgets to achieve desired results. There is an existing ticket with patch to support HTML5 input types (#16630). This is also addressed by the template-based-widgets patch in #15667. I think the latter is the best direction, but it is blocked by slowness of the template engine. > P.S. The submitted patch lacks tests. I could not figure out how to > write tests for the UI. If that is acceptable, can core devs please > accept the patch? Patches without tests won't be committed. There are many existing examples of tests that test form rendering and HTML output; for instance, most of the tests in regressiontests/forms/. Carl -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk84VFsACgkQ8W4rlRKtE2fqbgCfZF+38wR0kbsdLnQ2oM5JBfxn E0UAoOlnRgDVRXmuEaVPU2WsOe3C74Jh =yR2q -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
