On Wed, Mar 14, 2012 at 10:22 AM, Dan Fairs <dan.fa...@gmail.com> wrote: > - We have a custom template tag that derives from ExtendsNode, and overrides > get_parent > - We have a custom Library implementation that overrides inclusion_tag(), > which knows > about our template lookup logic; it broke because the signature for > generic_tag_compiler > changed. > > Both of these were fixed by using the new implementations from Django > itself, and re-applying our small changes. > > Should I raise backwards-incompatibility tickets for these? They're pretty > obscure, and I can't imagine many people are doing them. I raised #17891 > because the code involved a clear extension point.
Thanks for sharing this story, Dan! It's great to hear. Let us know about the performance differences (if any), too. Regarding backwards-incompatibility on those undocumented things, write up a patch for the release notes if you'd like. Specifically, add it to the "Backwards incompatible changes in 1.4" section in docs/releases/1.4.txt. Adrian -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
