Christian, have you seen the patch review checklist I put together? https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#patch-review-checklist
That is basically what I do when I review a patch. If a patch meets those guidelines, please mark it RFC. A core dev will always do a final review, but it helps a lot if we don't have to explain those basics to new contributors. Sure, you will make mistakes, but that is the only way to learn and the risks are low. Over time, the core team will see that the patches your mark as RFC are really RFC as you said, and we're likely to ask you the join the team so you can just commit those patches that you review yourself. Regarding Trac, would you mind explaining what Trac is blocking you from doing? Perhaps we can try to address some of those issues. On Friday, August 1, 2014 4:38:54 PM UTC-4, Christian Schmitt wrote: > > its a matter of trust. > gerrit tracks your reviews so its way easier to build up trust that the > things you mark as RFC is really RFC ;) > And yes its a matter of tooling since some tools provide a better way to > build trust for such community processes. > Also I'm quite young. I wouldn't want to make a "community review" just by > myself since I will definitely do some mistakes over time as everybody will > do. > > to come back to the tooling. gerrit is just one tool. i don't know more > than gerrit that has such a large feature set. but i think there are > definitly some out. > In our company we use a lot of atlassian tools and atlassian has a > "gerrit" tool, too but I didn't take a look at it yet. so thats another > option since atlassian tools are free for community use. > > the next thing is, reading contribution docks is easy, using trac is not. > trac is a really blocker for a lot of things on my side. i think the ux is > somewhat bad, but thats just an own perspective. > > > > > 2014-08-01 21:49 GMT+02:00 Carl Meyer <ca...@oddbird.net <javascript:>>: > >> Hi Christian, >> >> On 08/01/2014 01:37 PM, Schmitt, Christian wrote: >> [snip] >> > i mean maybe we should really look at a review tool and maybe say if two >> > people of the community reviewed it gets pipelined to the "core" which >> > can do a final review. so it would be more community oriented and fewer >> > "bad patches" will get to the commit pipeline. >> > still it takes a lot of time to teach people and setup everything. but >> > it will put the project further ahead. >> > (also I'm not a core member but if we had such a review system i >> > would definitely do more of these reviews since thats the thing i do at >> > my company, too) >> >> I'm curious why the system you propose (requiring two community reviews >> to fast-track a patch) would motivate you to do more reviews than the >> current system, in which it only takes a single review (by any community >> member) to mark a ticket as "Ready for Check-in", which already gets it >> fast-tracked for commit. >> >> Although it does happen sometimes, there isn't a big problem (AFAIK) >> with lots of patches getting marked RFC when they aren't ready; >> currently there are only 3 tickets in RFC state. The bigger problem is >> there aren't many people doing reviews and moving tickets to RFC state. >> According to dashboard.djangoproject.com, there are 52 patches awaiting >> review. >> >> Maybe it's mostly a tooling issue, in that the current process requires >> reviewers to read the contribution docs, understand the ticket state >> flow, and then use both GitHub and Trac and manually mark the ticket RFC >> themselves after doing a review, rather than having a review tool with a >> big +1 button on it that automatically handles the state changes. >> >> Carl >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-develop...@googlegroups.com <javascript:>. >> To post to this group, send email to django-d...@googlegroups.com >> <javascript:>. >> Visit this group at http://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/53DBEF42.8090000%40oddbird.net >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/e41b99a9-e998-48b9-871c-c9f8b2183728%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
