Hi Erik,

I've written such a patch, which also fixes an html escape bug and adds 
validation to the auth management commands.
The pull request is here <https://github.com/django/django/pull/4969>.

Sincerely,

Alex

On Friday, June 26, 2015 at 3:19:30 AM UTC-5, Erik Romijn wrote:
>
> Hi Alex, Carl, 
>
> On 22 Jun 2015, at 02:43, Carl Meyer <ca...@oddbird.net <javascript:>> 
> wrote: 
> > On 06/21/2015 06:17 PM, Alex Becker wrote: 
> >> With the PR merged, password validation applies to the SetPasswordForm 
> >> and the password changing forms, but not to the UserCreationForm or to 
> >> the creation of superusers. Is there a reason not to apply validation 
> to 
> >> these as well? 
> > 
> > Certainly makes sense to me to add validation to both of these. I missed 
> > it in review. Erik, is there a reason you didn't, or was it just an 
> > oversight? 
>
> No reason at all. I hadn’t even realised there was such a form. It seems 
> sensible to add it (along with a test), but I don’t have time to make the 
> patch currently. 
>
> Erik

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/0db36d3f-14f2-450f-87f6-0dc67c715e41%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to