> On 13 Aug 2015, at 08:39, Loïc Bistuer <loic.bist...@gmail.com> wrote: > > How about we deprecate contrib.flatpages: > > - I see people abuse it all the time (do way more with it than they should) > just because it's in core. > > - FlatpageFallbackMiddleware is hardly an example to follow. > > - It can easily live as a third-party app. > > Thoughts?
+1 Move it into another project under the django/ namespace. Jannis > > -- > Loïc > >> On Aug 12, 2015, at 05:43, Tim Graham <timogra...@gmail.com> wrote: >> >> Aymeric raised a ticket [1] noting that the FlatPage.enable_comments field >> appears in the admin by default, but isn't used anywhere which could be a >> bit confusing. It seems that django-contrib-comments has a moderation >> feature where you can specify a field on your model to control how comments >> are handled [2], so this was presumably used for that. I'm not sure removing >> the field is a great optional unless we introduce a setting to make the >> flatpage model swappable (do we want more of those?!) for backwards >> compatibility. A compromise could be to hide the field in the default >> ModelAdmin and let those who want it to enable it with a custom ModelAdmin. >> What do you think? >> >> [1] https://code.djangoproject.com/ticket/25262 >> [2] http://django-contrib-comments.readthedocs.org/en/latest/moderation.html >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-developers+unsubscr...@googlegroups.com. >> To post to this group, send email to django-developers@googlegroups.com. >> Visit this group at http://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/ddffdfa8-9c6c-4d42-a816-1717478313f5%40googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/A201319D-6EC9-486F-B789-1365B0372A7E%40gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/82D07380-B5BA-458E-9774-D7F69CEC6B76%40gmail.com. For more options, visit https://groups.google.com/d/optout.
