Hi Ryan, On 01/08/2016 11:48 AM, Ryan Hiebert wrote: > I hadn't considered the option of just returning ``get_response``. > I really like it, because it avoids both raising an exception and > importing a common symbol. > > While class-based middleware factories couldn't just do the same thing > in the __init__ method, they could do that in a __new__ method instead, > and then we could make returning the ``get_response`` function the > "one way to do it."
I'd be more sympathetic to this viewpoint if Django hadn't already had the `MiddlewareNotUsed` exception for many years in this very role. There's no reason to break it if we don't absolutely have to. And since we've got it, and it works in any scenario, it may as well be the preferred method. Implementing `__new__` is something many Python developers aren't familiar with and don't do regularly, so I think it's not a good choice as the primary recommendation. Also, disabling middleware at setup time isn't all that common, so an import isn't a big deal. That said, I expect plenty of people (probably myself included) to use the "just return ``get_response``" trick, whether it's documented or not, and I think that's totally fine. Carl -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/5690059B.90201%40oddbird.net. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
