Hi all,

I came across the need of modifying the submit row functionality in the 
django admin and I found out a small issue which prevents me from modifying 
the template without rewriting (duplicating) also the templatetag entirely.

If you take a look at the code of submit_row templatetag 
<https://github.com/django/django/blob/master/django/contrib/admin/templatetags/admin_modify.py#L41-L70>,
 
you will notice the original view context is not passed entirely to the 
return statement. A new ctx dictionary is created and filled only with a 
smaller subset of key/value pairs.

I took a quick look at other template tags and I noticed they return the 
entire context and not a stripped version of it.

I would prefer submit_row to behave in the same way as the other 
templatetags so I wouldn't have to duplicate its code to add new context 
values to it.
If there's consensus on this issue I can create a ticket and send a pull 
request, let me know.

Federico

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/8172f221-a312-4cae-b8ee-fd2e9f971b7c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to